Vehicle restricting

[ahref]

Im fed up with people coming on my server to drive around in a car ITS FLAT GRASS. so i want to restrict vehicles to only the prisoner pod so that none of the others can be spawned unless the player is an admin of course.

heres my current code and its not working:

Code: [Select]

function GAMEMODE:PlayerSpawnVehicle( ply, prop )

return spawned_vehicle( ply, prop )

end

function spawned_vehicle( ply, prop )
if ( SinglePlayer() ) then return true end
if ply:IsAdmin() or ply:IsSuperAdmin() then
return true
end
if ( prop != "prop_vehicle_prisoner_pod" ) then
ply:PrintMessage( HUD_PRINTTALK, "This is Garrys Mod BUILD A VEHICLE(seats and pods are still allowed)" ) 
return false
else
return true
end
end
what am i dont wrong?

[JamminR]

What isn't working? Non admins still allowed to spawn vehicles?

[ahref]

yes

[JamminR]

Few quick theories; test at your own pace.

I poked around in Garry's code by looking in gmod/gamemodes/sandbox .. player.lua and command.lua. (He REALLY needs to update code.garrysmod.com - it's quite out of date.
First;
Isn't prop_blah_blah an entity class, not a model? The references in his code all seem like it would be a model.
(Still seems that should return false though)

Second;
It's been my experience in Lua to place function BEFORE the call to the function. You currently have it backwards.
No idea if that's required for it to work, but it's definitely good practice.

Third;
Tried making functions local? See UNoLimited as an example. (I'm not 100% sure why Megiddo made them local, but I saw that it was, kept it that way, and it worked)
Also, part of this theory...anytime you attempt to spawn a prop, Gmod tries to check to see if the sbox_ limits are set for it... it's possible that function is getting called before yours is.

Fourth...
You're forcing this to run on the server and not the client, right?

Someone else could help here I'm sure.
I'm gonna go play some Fallout 3 now. Had no idea a "choose your own adventure" book (in theory) had been turned into a game.

[ahref]

yes i read unolimited to see how it worked. It also had an init function with nothing in it:

Code: [Select]

local function init()

and later on

hook.Add( "Initialize", "LimitInitilize", init )

@first - i can try models
@second - oo thats my fault i had a standard hook in there before.
@third - will try
@fourth - its in my server autorun

[ahref]

i tired this:

Code: [Select]

local function spawned_vehicle( ply, prop )
if ( SinglePlayer() ) then return true end
if ply:IsAdmin() or ply:IsSuperAdmin() then
return true
end
if ( prop:GetClass( ) != "prop_vehicle_prisoner_pod" ) then
ply:PrintMessage( HUD_PRINTTALK, "This is Garrys Mod BUILD A VEHICLE(seats and pods are still allowed)" ) 
return false
else
return true
end
end

function GAMEMODE:PlayerSpawnVehicle( ply, prop )

return spawned_vehicle( ply, prop )

end

as it seems from the example that it returns an entity not a propid :S

[JamminR]

Any errors in server console when non-admin spawns a vehicle?
Tried printing to your HUD or console what "prop" actually contains?
That line of troubleshooting would help you quickly ascertain how to go about checking it, whether it actually be a model, entity, or class.

Also - Tip for Lua best practice -

Code: [Select]

if ( prop:GetClass( ) != "prop_vehicle_prisoner_pod" ) then
Garry added several of his own programmng contructs to what I call 'G-Lua'. (Gmod Lua)
One of those is the "not equal" construct.
Though in Gmod your "!=" should work, best practice would be to not follow Garry's lead there.
I recommend using

Code: [Select]

if not prop:GetClass( ) == "prop_vehicle_prisoner_pod" thenThat makes it much easier to tell when debugging A should not equal B
There IS an 'abbreviated' way, but I find it's not as easy to see. The true not equal abbreviation in Lua is "~="
As you can see, that would be much more difficult to notice than Garry's "!=", and could easily be lost while looking at code

[JamminR]

http://wiki.garrysmod.com/wiki/?title=Gamemode.PlayerSpawnedVehicle
Try adding a hook rather than overwriting the Gamemode function.
You would need to change your "return true" lines to just "return"
"Return false" would remain the same

[ahref]

@G-Lua commens, Yeah that is better

@Hook, Would that still be able to deny the spawning of the vehicle?

[JamminR]

Yes.
Returning _anything_, I believe even including true, stops the Gmod function for spawning it.
So, that's why you'd remove the 'true' also
(Others, feel free to correct me on this)

Code: [Select]

local function spawned_vehicle( ply, prop )
   if ( SinglePlayer() ) then return end
   if ply:IsAdmin() or ply:IsSuperAdmin() then
      return
   end
   if not prop:GetClass( ) == "prop_vehicle_prisoner_pod" then
      ply:PrintMessage( HUD_PRINTTALK, "This is Garrys Mod BUILD A VEHICLE (seats and pods are still allowed)" )
      return false
   else
      return
   end
end

hook.Add( "PlayerSpawnedVehicle", "CheckIfCar", spawned_vehicle )


[ahref]

found out its returning:

Code: [Select]


Redownloading all lightmaps
Airboat
ahref<UNKNOWN> spawned vehicle models/airboat.mdl
Pod
ahref<UNKNOWN> spawned vehicle models/nova/airboat_seat.mdl
Vehicle
ahref<UNKNOWN> spawned vehicle models/buggy.mdl
Pod
ahref<UNKNOWN> spawned vehicle models/nova/jeep_seat.mdl
Pod
ahref<UNKNOWN> spawned vehicle models/nova/chair_office01.mdl
Pod
ahref<UNKNOWN> spawned vehicle models/nova/chair_office02.mdl
Pod
ahref<UNKNOWN> spawned vehicle models/props_phx/carseat2.mdl

which is really odd. but ohwell makes the code easier.

so it is now:

Code: [Select]

local function spawned_vehicle( ply, prop )
if ( SinglePlayer() ) then return true end
if ply:IsAdmin() or ply:IsSuperAdmin() then
return
end
if not prop:GetClass( ) == "Pod"  then
ply:PrintMessage( HUD_PRINTTALK, "This is Garrys Mod BUILD A VEHICLE(seats and pods are still allowed)" ) 
return false
else
return
end
end
hook.Add( "PlayerSpawnedVehicle", "ahrefspawnedvehicle", spawned_vehicle )
qhich doesnt work but ill keep poking

[JamminR]

OOps.
Sorry. Hook PropSpawnedVehicle will not work.
From it's description - Bold'ed for clarity
"Called when a player has already spawned a vehicle. Use this to record the vehicle's propid. Useful for prop protection.

See http://wiki.garrysmod.com/wiki/?title=Gamemode.PlayerSpawnProp for better way.

[ahref]

now im at this:

Code: [Select]

local function spawned_vehicle( ply, prop, ent )
if ( SinglePlayer() ) then return true end
if ply:IsAdmin() or ply:IsSuperAdmin() then
return
end
if not ent:GetClass( ) == "prop_vehicle_prisoner_pod"  then
ply:PrintMessage( HUD_PRINTTALK, "This is Garrys Mod BUILD A VEHICLE(seats and pods are still allowed)" ) 
return false
else
return
end
end
hook.Add( "PlayerSpawnProp", "ahrefspawnedvehicle", spawned_vehicle );

which doesnt work. at this point is probably just me though

[JamminR]

The Gmod wiki article for PlayerSpawnedProp mentions nothing of your 3rd variable "ent" passed to your function.
Did you find code or mention of it somewhere?
Does 'Ent' actually get passed to it?

[ahref]

sigh. i had a tab open with a hook. that had the 3 inputs must've asumed it was spawnprop. right now to get those model names