ULX

Author Topic: Admins can be banned via Voteban  (Read 2327 times)

0 Members and 1 Guest are viewing this topic.

Offline Lolomat

  • Newbie
  • *
  • Posts: 24
  • Karma: 0
Admins can be banned via Voteban
« on: September 29, 2014, 10:38:25 AM »
Hello Folks,

i have a Problem. I run ULX and ULib in the SVN Version. And somehow, from one day to the next day, there appeared a bug. This bug allows normals Users to voteban Admins. Then i specified !%admin,!%operator,!&donator,!%superadmin for the Voteban/Kick/Gag command itself. This worked for a few days. Then the bug appeared again. I also tried to reinstall the whole ULX and Lib. Didn't help.

Did someone else had this bug before? Or did i something wrong?

Regards,
Lolomat

Offline Neku

  • Hero Member
  • *****
  • Posts: 549
  • Karma: 27
Re: Admins can be banned via Voteban
« Reply #1 on: September 29, 2014, 12:08:08 PM »
That's not a bug.
Out of the Garry's Mod business.

Offline Lolomat

  • Newbie
  • *
  • Posts: 24
  • Karma: 0
Re: Admins can be banned via Voteban
« Reply #2 on: September 29, 2014, 02:31:01 PM »
What is it then?

Offline Zmaster

  • Full Member
  • ***
  • Posts: 235
  • Karma: 25
Re: Admins can be banned via Voteban
« Reply #3 on: September 29, 2014, 02:41:23 PM »
What is it then?

It's just something that they could prevent but didn't
It's not on purpose or on accident
Not a bug
Just...not prevented

Offline Neku

  • Hero Member
  • *****
  • Posts: 549
  • Karma: 27
Re: Admins can be banned via Voteban
« Reply #4 on: September 29, 2014, 04:22:43 PM »
If you want to prevent the abuse of Voteban, then limit the amount of time that the target can be banned, say 5-10 minutes.
Out of the Garry's Mod business.

Offline Lolomat

  • Newbie
  • *
  • Posts: 24
  • Karma: 0
Re: Admins can be banned via Voteban
« Reply #5 on: October 01, 2014, 01:06:46 PM »
I'm confused.
I thought the can_target is made to "protect" groups from other groups.
If i set !%admin on group user, Group user shouldn't be able to voteban/kick/gag players in group admin. Especially when i also set the same can_target for the command it self. Or did i get something wrong?

Offline JamminR

  • Ulysses Team Member
  • Hero Member
  • *****
  • Posts: 8096
  • Karma: 390
  • Sertafide Ulysses Jenius
    • Team Ulysses [ULib/ULX, other fine releases]
Re: Admins can be banned via Voteban
« Reply #6 on: October 01, 2014, 02:32:41 PM »
By default, "user" group doesn't have access to ulx voteban for just that reason... it could be abused.
Voteban is intended as a means to allow an admin (default group that has voteban access) to start a voteban to allow users to have their say whether or not anyone should be banned, including other admins/superadmins/higher groups if needed.
Adding the can_target check to voteban would prevent that from happening.

If you have "user" access group abusing voteban privilege, don't allow "user" group to have full access to it.
Give full access to admin or other trusted group only.
Then, if you just must give access to users, restrict the time allowed as indicated.

If you're having issue with ALL the vote commands, then you have an inheritance tree issue somewhere in your groups, and while an affected group member is connected to the server, need to attach the file created from the server console command "ulx debuginfo" to your next post.
"Though a program be but three lines long, someday it will have to be maintained." -- The Tao of Programming