General > Developers Corner

Banid and kickid don't check can target

(1/3) > >>

BigBrainAFK:
Hello,

as I mentioned in another thread I have the problem that everyone with banid / kickid rights can ban / kick every SteamID even if the SteamID is from an user in a group that he can't target.

MrPresident:
When you ban or kick an ID, it just does it. It doesn't reverse check the ID and compare it against a possible list of users and their groups.

An ID is an ID, it's not a player and therefor doesn't have a group for ULX to check against.
If you have people abusing kickid and banid then revoke their access to that command.

I may not speak for the rest of the team, but we're not going to go out of the way and make things more complicated because server owners are giving command access to players who are abusing them.

Bytewave:
This is a known feature of ULX/ULib (if you're speaking of 'ulx banid').
Commands involving SteamIDs do NOT check for a player/group's can_target value, as it would be a waste of resources. If you don't want people to be able to ban SteamIDs they're not meant to, don't give them access to 'ulx banid'.

If you're talking about the stock Source kickid/banid, those commands are not touched by ULX/ULib, and therefore do not check can_target.

Pre-Post Edit: Mr. Pres, ya beat me to it.

--- Quote from: MrPresident on April 25, 2015, 03:32:28 PM ---When you ban or kick an ID, it just does it. It doesn't reverse check the ID and compare it against a possible list of users and their groups.

An ID is an ID, it's not a player and therefor doesn't have a group for ULX to check against.
If you have people abusing kickid and banid then revoke their access to that command.

I may not speak for the rest of the team, but we're not going to go out of the way and make things more complicated because server owners are giving command access to players who are abusing them.

--- End quote ---

JamminR:
BigBrain, apologies for not recognizing what you were asking sooner in another thread.
What they said - we wrote in ulx banid to allow superadmins to ban people who had, mostly, left the server, or might not even have ever joined (forums sometimes share bad troublemaker steamids)
That 'todo' is still extremely low on our priorities.
http://forums.ulyssesmod.net/index.php/topic,6906.msg34062.html#msg34062

BigBrainAFK:
I don't know if implementing a groupcheck is that hard cause you gave me a simple solution that works pretty well (and no I don't have a server with just 50 or 60 players in ULib :D).

I would recommend to add a controlbox so you can switch on/off the check at banid

Navigation

[0] Message Index

[#] Next page