Poll

How would you feel if ULX implemented error sharing?

That is fine with me
I would be upset if it was enabled by default, but would probably enable it
I would never use or want this

Author Topic: Feedback wanted: Sharing errors?  (Read 2568 times)

0 Members and 1 Guest are viewing this topic.

Offline Megiddo

  • Ulysses Team Member
  • Hero Member
  • *****
  • Posts: 6213
  • Karma: 394
  • Project Lead
Feedback wanted: Sharing errors?
« on: February 18, 2016, 04:31:45 AM »
How would you all feel about a ULX feature that would automatically send us (Team Ulysses) Lua error information if the error is related to ULX? Data sent would include things like ULX version data, a stack trace, and possibly the variables in use at the error location.

This information would be anonymous and used only for fixing potential problems in ULX.
Experiencing God's grace one day at a time.

Offline Bytewave

  • Respected Community Member
  • Hero Member
  • *****
  • Posts: 718
  • Karma: 116
  • :)
    • My Homepage
Re: Feedback wanted: Sharing errors?
« Reply #1 on: February 18, 2016, 08:59:52 AM »
I know how nice it is to have errors sent to you so people don't always have to report them, but my biggest concern is implementation.

You have two problems that may arise, and I'm curious as to how you'd address them.
  • Error-prone servers. Chances are, most servers aren't perfect, especially those without experienced development staff---just servers with addons thrown at them until they stick. I've seen a lot of cases in my own experience where there are a looot of errors in the backend that would possibly affect UL(ib|X){1} functions. Presumably any overrides on error handlers that submit error data could DoS your collection server unintentionally if they submit too many requests. Not sure how you'd deal with that... maybe a cooldown? But then you might miss something important from a server without too many errors if two appear right after each other.
  • Server load. Though the network request may be small, a smaller server may have trouble POSTing to an HTTP server; who knows what they're running with? That's an easy fix, though---opt-in, not opt-out. :p
bw81@ulysses-forums ~ % whoami
Homepage

Offline Megiddo

  • Ulysses Team Member
  • Hero Member
  • *****
  • Posts: 6213
  • Karma: 394
  • Project Lead
Re: Feedback wanted: Sharing errors?
« Reply #2 on: February 18, 2016, 09:12:17 AM »
On #1, I'm only exploring the concept right now. I have some ideas on implementation details for those types of concerns, but was curious what the community would have to say about it first.

On #2, if you can't post 512 Kb of text once in a great while, you have much, much larger problems.
Experiencing God's grace one day at a time.

Offline Bytewave

  • Respected Community Member
  • Hero Member
  • *****
  • Posts: 718
  • Karma: 116
  • :)
    • My Homepage
Re: Feedback wanted: Sharing errors?
« Reply #3 on: February 18, 2016, 11:31:11 AM »
On #2, if you can't post 512 Kb of text once in a great while, you have much, much larger problems.
That mostly ties in with #1. But yknow.
bw81@ulysses-forums ~ % whoami
Homepage

Offline feldma

  • Newbie
  • *
  • Posts: 47
  • Karma: 5
  • 5696 hours in Gmod and counting!
    • Mega-Strike Network
Re: Feedback wanted: Sharing errors?
« Reply #4 on: February 18, 2016, 12:34:08 PM »
It sounds like a good idea, but I think it needs to be turned off by default.

Solving 50% of people's questions by searching it up on google.

Trying to think of a cool idea to code, so I can inspire myself to code. If you want something done, please message me!

Offline Bytewave

  • Respected Community Member
  • Hero Member
  • *****
  • Posts: 718
  • Karma: 116
  • :)
    • My Homepage
Re: Feedback wanted: Sharing errors?
« Reply #5 on: February 18, 2016, 04:40:37 PM »
It sounds like a good idea, but I think it needs to be turned off by default.
Most definitely. Maybe a little prompt on first run, like most installers on programs:

Would you like to share ULX/ULib error data with Team Ulysses in order to assist the debugging process?
    Yes     No

and then store that value in the config. Or forego the prompt entirely and just throw it in XGUI for people to find, but I doubt you'd get many results there.
bw81@ulysses-forums ~ % whoami
Homepage

Offline WispySkies

  • Full Member
  • ***
  • Posts: 144
  • Karma: 0
  • I make random commands and Lua errors.
Re: Feedback wanted: Sharing errors?
« Reply #6 on: February 19, 2016, 11:03:11 AM »
I like the idea. :D
Although this may be tedious, have it disabled on default, and when an error arises you can then run a command that reports errors of your choice -- like a menu to select what errors you want to report. But in doing so this would most likely take a lot of work & time.

most servers aren't perfect, especially those without experienced development staff---just servers with addons thrown at them until they stick.
That's exactly what I do. ;)

Offline Megiddo

  • Ulysses Team Member
  • Hero Member
  • *****
  • Posts: 6213
  • Karma: 394
  • Project Lead
Re: Feedback wanted: Sharing errors?
« Reply #7 on: February 21, 2016, 02:02:44 PM »
Perhaps the best method is to have a panel popup after error(s) occur, showing exactly what would be sent, like how some desktop applications work.

My concern with opt-in is that I am fairly certain that no one would ever enable it without severe prodding. And if no one would enable it, it's not worth the time to develop this feature even though it has the potential to help everyone.
Experiencing God's grace one day at a time.

Offline MrPresident

  • Ulysses Team Member
  • Hero Member
  • *****
  • Posts: 2728
  • Karma: 430
    • |G4P| Gman4President
Re: Feedback wanted: Sharing errors?
« Reply #8 on: February 21, 2016, 02:49:44 PM »
How about 'On' by default, but a popup on first run that let's the superadmin know the feature is turned on and what it will send and allow them the option to easily disable it from that popup.

If they choose to disable it, we can display to them where they can go to enable it if they choose.

Offline Megiddo

  • Ulysses Team Member
  • Hero Member
  • *****
  • Posts: 6213
  • Karma: 394
  • Project Lead
Re: Feedback wanted: Sharing errors?
« Reply #9 on: February 21, 2016, 03:43:34 PM »
That seems like a workable solution
Experiencing God's grace one day at a time.