Ulysses

General => Developers Corner => Topic started by: thomasfn on March 08, 2009, 08:07:47 AM

Title: ULib breaks datastream
Post by: thomasfn on March 08, 2009, 08:07:47 AM

Sorry if this is in wrong place, or w/e.

Already sent off a bug report about this:
http://ulyssesmod.net/bugs/view.php?id=348 (http://ulyssesmod.net/bugs/view.php?id=348)

But it's important this is fixed asap.

Code: [Select]

When using the datastream module (now included in GMod by default) clientside, ULib errors out and datastream fails to deliver data.

Using datastream.StreamToServer on the client. Error is serverside.

ULib/server/hook.lua:139: attempt to index local 'gm' (a nil value)

This causes compatability issues with PCMod 2, stopping a core feature from working. Any other mod that uses clientside datastream will break completely.

This is not a problem with my code, or datastream code, but with ULib overriding the hook library badly. It needs to be fixed asap, since ULX is basically breaking a GMod function.
Many people use PCMod 2 and ULX on their servers, and since PCMod 2 uses clientside datastream, ULX breaks it.

Title: Re: ULib breaks datastream
Post by: Megiddo on March 08, 2009, 10:21:42 AM

Argh. I told the author of Datastream not to do this; guess he didn't listen to me.

Title: Re: ULib breaks datastream
Post by: thomasfn on March 08, 2009, 01:50:49 PM

Well, I don't know how much of this is LuaBanana's fault, or what exactly the problem is, but is there a chance you could add the fix into the next release/svn? I'm getting alot of complaints that the save feature is not working, and I don't want to have to give people a file to override hook.lua with. (I posted a fix on mantis)

Title: Re: ULib breaks datastream
Post by: Megiddo on March 08, 2009, 02:15:26 PM

Testing the change now... will have it on SVN later today as long as it doesn't break anything.

EDIT: Fixed in rev 24