Ulysses

Ulysses Stuff => General Chat & Help and Support => Topic started by: eagle9er9er on March 12, 2015, 09:12:42 PM

Title: Demoted when someone rejoins.
Post by: eagle9er9er on March 12, 2015, 09:12:42 PM
I don't know if anyone else is having this issue, but whenever someone joins (for the first time between a restart/crash), and then leaves and rejoins, they join as a guest regardless of the rank they were in before they left. This issue is very irritating because donators get demoted to guest when they rejoin, and auto promote then promotes them to whatever rank their hours are at. I've removed all my ulx addons, reinstalled ulx, and I am at a total loss.

Even admins, and myself as owner get demoted when rejoining. I can't figure out what is causing it.
Title: Re: Demoted when someone rejoins.
Post by: Caustic Soda-Senpai on March 12, 2015, 09:28:14 PM
Do you have the auto demote enabled?
Title: Re: Demoted when someone rejoins.
Post by: eagle9er9er on March 12, 2015, 09:28:48 PM
No. The addon does not demote anyone. They literally just join as a guest, nothing else.
Title: Re: Demoted when someone rejoins.
Post by: JamminR on March 12, 2015, 09:56:15 PM
If DarkRp,
1) disable Fadmin
2) don't try to set any group hiigher than superadmin
3) crashes may not save some things (but a restart naturally through map change/etc shouldn't kill it)

Also, make sure you're not confusing "groups" with "ranks". I've no idea what ranks are in relation to DarkRP. For all I know, DarkRP "ranks" could be "teams", and, teams have nothing to do with groups.
Title: Re: Demoted when someone rejoins.
Post by: eagle9er9er on March 12, 2015, 09:57:17 PM
Sandbox :(, forgot to mention. And superadmin is the owner rank on my server.

And by ranks, i meant groups. Sorry. Ulx groups specifically.

Say I am in the superadmin group, all is fine until i disconnect and rejoin (before a crash or restart happens), and I join in the "user" group. Same goes for anyone in any ulx group.
Title: Re: Demoted when someone rejoins.
Post by: JamminR on March 12, 2015, 10:00:01 PM
Using latest Ulib and ULX downloaded from our downloads page? (or our github), and no where else, right?
See our FAQ "Having trouble with access?" in our FAQ section if sure you're using latest.
Again, all people who join a server are "users" according to Gmod (and ULX).
There is no "guest"
Title: Re: Demoted when someone rejoins.
Post by: eagle9er9er on March 12, 2015, 10:01:18 PM
Yes I have the svn hooked up to my server so anytime u guys update its automatic.

edit: my wording is horrible and i apologize if you are having a hard time understanding me. whenever i said guest i was referring to the "user" group.
Title: Re: Demoted when someone rejoins.
Post by: Stranger Danger on March 12, 2015, 11:04:56 PM
I'm from eagle9er9er's server. I also wanted to add that I re installed ulx and ulib which didn't fix. Also to clarify that people only get demoted to user when they rejoin, if the server restarts everyone has their correct rank/group.
Title: Re: Demoted when someone rejoins.
Post by: lynx on March 13, 2015, 12:13:52 AM
What's the size (kb or number of lines) of your users.txt file?

Should be in /data/ulib

Thinking this is related to https://github.com/Nayruden/Ulysses/issues/302
Title: Re: Demoted when someone rejoins.
Post by: eagle9er9er on March 13, 2015, 08:51:01 AM
I tried that, I backup my user.txt file, and then deleted everything inside of it, and restarted and the demotion still occured.
Title: Re: Demoted when someone rejoins.
Post by: JamminR on March 13, 2015, 09:07:32 AM
Please follow, at minimum, step 5 of the FAQ "Having trouble with access?"
Title: Re: Demoted when someone rejoins.
Post by: Stranger Danger on March 13, 2015, 12:35:45 PM
Please follow, at minimum, step 5 of the FAQ "Having trouble with access?"

*Due to text being to large I have to use pastebin*

The problem we are having is that when people rejoin the server their rank is being reset to guest(guest is the user rank). This only occurs when people rejoin though. If the server restarts they get their correct rank, even if they were demoted to wrong rank before the server restarts. For example I am SuperAdmin, if I first join the server everything is fine, but if I rejoin the server I get demoted to user and apromote promotes me to my appropriate rank as far as my hours go(SuperAdmin is excluded in apromote). So say I am now the ruby rank, if I restart the super I join as SuperAdmin, my correct rank.

Okay, I joined the server as superadmin like I should have. I ran ulx debuginfo and got this http://pastebin.com/euB3vDTv (http://pastebin.com/euB3vDTv)

I then typed retry into console rejoining the server as guest(guest is user rank), apromote then sees my hours and promotes me to ruby and I get this for ulx debuginfo. http://pastebin.com/hcSM5kYJ (http://pastebin.com/hcSM5kYJ)

Any help would be much appreciated thanks.

What's the size (kb or number of lines) of your users.txt file?

Should be in /data/ulib

Thinking this is related to https://github.com/Nayruden/Ulysses/issues/302 (https://github.com/Nayruden/Ulysses/issues/302)
*edit* Just a reminder we deleted user.txt as suggested here.
Title: Re: Demoted when someone rejoins.
Post by: JamminR on March 13, 2015, 12:56:24 PM
I don't know if anyone else is having this issue,
<clip> and auto promote then promotes them to whatever rank their hours are at.
<clip> I've removed all my ulx addons, reinstalled ulx, and I am at a total loss.

Even admins, and myself as owner get demoted when rejoining. I can't figure out what is causing it.

I'm sorry.
I totally missed key details and finally realized you were still running autopromote after your last post.
You said in your first post you'd removed all ulx addons.
I mistook that for having removed ALL addons and the issue still occurring.

This is an autopromote issue, not ULX.
The author of autopromote, IF they were still updating, could write hooks to verify ULX was completed adjusting permissions, or write in 'don't touch' group checks.
See this post. - http://forums.ulyssesmod.net/index.php/topic,7993.0.html (http://forums.ulyssesmod.net/index.php/topic,7993.0.html)
I blame 2 things - 1) Autopromote - getting stuck in a race and it winning/adjusting group before ULX has chance to and 2) Size of users file due to Autopromote causing slow down of ULX.
Sure, A tiny bit of it is due to the way we store our users, yes, but, you shouldn't expect to have every player who joins a server remembered in a group access file after only a few short hours of play.

The fix from that post was that the person cleaned out his users.txt file.
Title: Re: Demoted when someone rejoins.
Post by: Stranger Danger on March 13, 2015, 01:00:28 PM
As I stated earlier we deleted users.txt and had ulib rebuild it. Our user.txt file now only contains 5 people, we also have apromote through server collections and removed it from collections and the problem still persisted. We re added apromote after seeing it wasn't the problem. There is a delay in Apromote, when someone rejoins and in wrong rank there is about 2 seconds before apromote makes them their correct rank(based on hours not special ranks like admin). So unless ulx takes more than 2 seconds to put person in their correct rank I don't think its the issue.

Also to clarify this bug wasn't occurring until after Gmod update.

users.txt
Code: [Select]
"STEAM_0:0:62472963"
{
"allow"
{
}
"name" "camroblyer???? ? -- - "
"deny"
{
}
"group" "honored"
}
"STEAM_0:0:27700384"
{
"name" "???Vader"
"deny"
{
}
"allow"
{
}
"group" "superadmin"
}
"STEAM_0:1:20733228"
{
"name" "???Stranger ???Danger"
"deny"
{
}
"allow"
{
}
"group" "superadmin"
}
"STEAM_0:0:107086505"
{
"name" "Foxy"
"deny"
{
}
"allow"
{
}
"group" "bronze"
}
"STEAM_0:1:51877827"
{
"deny"
{
}
"allow"
{
}
"name" "doge_knight"
"group" "gold"
}

Title: Re: Demoted when someone rejoins.
Post by: JamminR on March 13, 2015, 01:18:08 PM
I'm now even more confused.
I thought the issue was "after a rejoin, autopromote then places the user in the group for that many hours instead of ULX placing them in the ULX assigned group"

Could someone please describe what happens after server is shut down, all autopromote addons/subscriptions are removed from server, server is started back up, someone joins, then rejoins, and the small/rebuilt users.txt file is used?

Title: Re: Demoted when someone rejoins.
Post by: Stranger Danger on March 13, 2015, 01:27:40 PM
I'm now even more confused.
I thought the issue was "after a rejoin, autopromote then places the user in the group for that many hours instead of ULX placing them in the ULX assigned group"

Could someone please describe what happens after server is shut down, all autopromote addons/subscriptions are removed from server, server is started back up, someone joins, then rejoins, and the small/rebuilt users.txt file is used?

Quote
I thought the issue was "after a rejoin, autopromote then places the user in the group for that many hours instead of ULX placing them in the ULX assigned group"

Yes(kinda), Apromote is only placing people in a group based on their hour (example ruby) because ulx is not placing them in their correct group when they join(example admin). My assigned role is superadmin. When I join the server for the first time I am Superadmin when I join. Not promoted, but automatically superadmin. But if I rejoin however, I join in as guest(guest is user group), so the lowest rank. After about 2 seconds I get (Console) added You to group ruby, which is apromote adding me to ruby based on my hours. Now if I stay as ruby and the server restarts, I go back to my correct group as SuperAdmin.

If you would like to see this first hand I would gladly show you. You can add me here. http://steamcommunity.com/profiles/76561198001732185 (http://steamcommunity.com/profiles/76561198001732185)

Thanks you for your continued help.
Title: Re: Demoted when someone rejoins.
Post by: Stranger Danger on March 13, 2015, 01:42:11 PM
-snip-
Title: Re: Demoted when someone rejoins.
Post by: JamminR on March 13, 2015, 02:02:59 PM
Me seeing doesn't really make it not happen, and I wouldn't know how to diagnose it from server end (other than if on my own server removing every single addon I'd ever subscribed/added, restarting server to make sure I was vanilla, then trying again)

So, with 100% certainty, if you disable/remove all autopromote scripts, restart server, join server, rejoin server, you're no longer superadmin?

Tried clearing lua and downloads cache on your client?
Tried removing (if installed) Ulib and ULX on your client?
Title: Re: Demoted when someone rejoins.
Post by: eagle9er9er on March 15, 2015, 01:29:27 PM
After an hour of trial and error i found out it was the bailout addon causing demotions. You can lock this.
Title: Re: Demoted when someone rejoins.
Post by: Bite That Apple on March 15, 2015, 07:27:54 PM
So is this one of my addons issues, if so, I'll attempt to fix it.
Title: Re: Demoted when someone rejoins.
Post by: Stranger Danger on March 17, 2015, 10:31:52 AM
So is this one of my addons issues, if so, I'll attempt to fix it.

No it was determined to be the bailout addon which is a addon that lets you rocket out of a chair and fall slowly with a parachute, the problem didn't involve apromote. Thanks for staying up to date with your addons.
Title: Re: Demoted when someone rejoins.
Post by: JamminR on March 17, 2015, 07:49:23 PM
Now the interesting question is in my mind... what the HECK was in a chair/parachute mod that would cause GROUP access to be lost?
Badly written PlayerInit/PlayerSpawn/PlayerAuth hook functions?
I don't want to look at the code, but *cringe*, I can't fathom why it should affect group checks.