ULX breaks on some XGUI menus

[Scratch]

Long story short, our moderators mentioned that they could not ban players using their name.

Upon trying it myself in the xgui, I found that the gui remained mostly frozen on my display
I further noticed I was getting errors in the server console

[ERROR] addons/ulib/lua/ulib/shared/misc.lua:703: attempt to perform arithmetic on local 'num' (a nil value)
1. stringTimeToSeconds - addons/ulib/lua/ulib/shared/misc.lua:703
2. processRestrictions - addons/ulib/lua/ulib/shared/commands.lua:189
3. x_getcontrol - addons/ulx/lua/ulx/modules/cl/xgui_helpers.lua:231
4. obj - addons/ulx/lua/ulx/xgui/commands.lua:210
5. func - addons/ulx/lua/ulx/modules/cl/xlib.lua:1080
6. animQueue_call - addons/ulx/lua/ulx/modules/cl/xlib.lua:1061
7. func - addons/ulx/lua/ulx/modules/cl/xlib.lua:1080
8. animQueue_call - addons/ulx/lua/ulx/modules/cl/xlib.lua:1061
9. animQueue_start - addons/ulx/lua/ulx/modules/cl/xlib.lua:1048
10. OnSelect - addons/ulx/lua/ulx/xgui/commands.lua:109
11. unknown - lua/vgui/dlistview_line.lua:94

I stopped the server, deleted ulib and ulx from the addons, and downloaded the ZIP versions of the addons, then uploaded them onto the server, hopefully fixing the issue (It didn't)

Code: [Select]

ULX version: 3.60
ULib version: 2.50
Gamemode: Trouble in Terrorist Town
Map: ttt_67thway_v3
Dedicated server: true

Currently connected players:
Nick                            steamid            uid        id lsh
aPlethoraOfPlatypi              STEAM_0:1:47104014 3812254862 1  n  
KnownJew                        STEAM_0:1:38097147 333433934  2  n  
Picnic Is BukLau                STEAM_0:0:37487273 3763503357 3  n  
j.megg99                        STEAM_0:0:66366011 3252334574 4  n  


ULib.ucl.users (#=30):
STEAM_0:0:32493517:
allow:
name = Scratch
deny:
group = moderator
STEAM_0:0:29071677:
allow:
name = GingerBeer:)
deny:
group = moderator
STEAM_0:1:41538839:
deny:
allow:
name = Buzz Goat Year
group = donator
STEAM_0:0:56107579:
allow:
name = MrRattlehead18
deny:
group = moderator
STEAM_0:1:33348246:
allow:
name = Sage
deny:
group = donator
STEAM_0:0:16289435:
deny:
allow:
group = superadmin
STEAM_0:1:29068596:
allow:
name = Humg12
deny:
group = moderator
STEAM_0:0:47925064:
name = joelza1000
allow:
deny:
group = donator
STEAM_0:1:28483420:
deny:
allow:
group = superadmin
STEAM_0:0:46130468:
allow:
name = [SUNS] Ezio
deny:
group = donator
STEAM_0:0:49871796:
name = XxB4TM4NxX
deny:
allow:
group = donator
STEAM_0:1:44549299:
allow:
name = JayxBacon
deny:
group = moderator
STEAM_0:1:48622864:
deny:
allow:
name = Dman
group = donator
STEAM_0:0:395474100:
allow:
deny:
group = moderator
STEAM_0:1:20515792:
name = James
deny:
allow:
group = james' group of himself
STEAM_0:0:29351088:
allow:
name = Zelpa
deny:
group = donator
STEAM_0:0:37141731:
deny:
allow:
name = Skulzie
group = donator
STEAM_0:0:032493517:
allow:
deny:
group = admin
STEAM_0:1:562591111:
allow:
deny:
group = moderator
STEAM_0:0:16487722:
name = HayHay
deny:
allow:
group = moderator
STEAM_0:0:1026502:
deny:
allow:
name = Lantrix
group = admin
STEAM_0:0:56546654:
name = Swivel
deny:
allow:
group = donator
STEAM_0:0:18854641:
allow:
name = Video JAAAAAAAAMES
deny:
group = donator
STEAM_0:1:26659411:
deny:
allow:
name = Jords
group = donator
STEAM_0:0:37239602:
deny:
allow:
name = HarmlessTank
group = admin
STEAM_0:0:39126122:
deny:
allow:
group = donator
STEAM_0:0:34990510:
allow:
name = Vairan
deny:
group = moderator
STEAM_0:1:51755355:
name = Anon
deny:
allow:
group = donator
STEAM_0:0:46759837:
name = xX_Ace_Xx
deny:
allow:
group = donator
STEAM_0:0:46459259:
deny:
allow:
name = DylzaNZ
group = donator


ULib.ucl.groups (#=6):
moderator:
can_target = !%admin
allow:
1 = ulx afk
2 = ulx banid
3 = ulx bring
4 = ulx gag
5 = ulx gimp
6 = ulx kick
7 = ulx seeasay
8 = ulx slay
9 = ulx tsay
10 = ulx unban
11 = ulx ungag
12 = ulx ungimp
13 = ulx vslaynr
ulx slaynr = * 1
ulx ban = * 1~5160
inherit_from = donator
donator:
allow:
1 = ulx vote
2 = ulx votekick
3 = ulx votemap2
inherit_from = user
admin:
can_target = !%superadmin
allow:
1 = ulx adduser
2 = ulx adduserid
3 = ulx armor
4 = ulx ban
5 = ulx blind
6 = ulx bodyarmor
7 = ulx bring
8 = ulx chattime
9 = ulx cloak
10 = ulx csay
11 = ulx freeze
12 = ulx gag
13 = ulx gimp
14 = ulx god
15 = ulx goto
16 = ulx hp
17 = ulx ignite
18 = ulx jail
19 = ulx jailtp
20 = ulx karma
21 = ulx kick
22 = ulx kickafternamechanges
23 = ulx kickafternamechangescooldown
24 = ulx kickafternamechangeswarning
25 = ulx map
26 = ulx mute
27 = ulx noclip
28 = ulx nr
29 = ulx physgunplayer
30 = ulx playsound
31 = ulx ragdoll
32 = ulx removeuser
33 = ulx reservedslots
34 = ulx respawn
35 = ulx rslaynr
36 = ulx rslots
37 = ulx rslotsmode
38 = ulx rslotsvisible
39 = ulx seeanonymousechoes
40 = ulx send
41 = ulx showmotd
42 = ulx slap
43 = ulx slay
44 = ulx slaynr
45 = ulx spawnecho
46 = ulx spectate
47 = ulx sslay
48 = ulx strip
49 = ulx teleport
50 = ulx tsay
51 = ulx unban
52 = ulx unblind
53 = ulx uncloak
54 = ulx unfreeze
55 = ulx ungag
56 = ulx ungimp
57 = ulx ungod
58 = ulx unignite
59 = ulx unigniteall
60 = ulx unjail
61 = ulx unmute
62 = ulx unragdoll
63 = ulx veto
64 = ulx vote
65 = ulx voteban
66 = ulx votebanminvotes
67 = ulx votebansuccessratio
68 = ulx votekick
69 = ulx votekickminvotes
70 = ulx votekicksuccessratio
71 = ulx votemap2
72 = ulx votemap2minvotes
73 = ulx votemap2successratio
74 = ulx votemapenabled
75 = ulx votemapmapmode
76 = ulx votemapmintime
77 = ulx votemapminvotes
78 = ulx votemapsuccessratio
79 = ulx votemapvetotime
80 = ulx votemapwaittime
81 = ulx vslaynr
82 = ulx welcomemessage
83 = ulx whip
84 = xgui_managebans
85 = xgui_managegroups
inherit_from = moderator
superadmin:
allow:
1 = ulx addgroup
2 = ulx adduser
3 = ulx adduserid
4 = ulx afk
5 = ulx banid
6 = ulx cexec
7 = ulx credits
8 = ulx ent
9 = ulx exec
10 = ulx force
11 = ulx groupallow
12 = ulx groupdeny
13 = ulx hiddenecho
14 = ulx karma
15 = ulx logchat
16 = ulx logdir
17 = ulx logecho
18 = ulx logechocolorconsole
19 = ulx logechocolordefault
20 = ulx logechocoloreveryone
21 = ulx logechocolormisc
22 = ulx logechocolorplayer
23 = ulx logechocolorplayerasgroup
24 = ulx logechocolors
25 = ulx logechocolorself
26 = ulx logevents
27 = ulx logfile
28 = ulx logjoinleaveecho
29 = ulx logspawns
30 = ulx logspawnsecho
31 = ulx luarun
32 = ulx maul
33 = ulx nr
34 = ulx rcon
35 = ulx removegroup
36 = ulx removeuser
37 = ulx removeuserid
38 = ulx renamegroup
39 = ulx respawn
40 = ulx setgroupcantarget
41 = ulx sforce
42 = ulx srespawn
43 = ulx unafk
44 = ulx userallow
45 = ulx userallowid
46 = ulx userdeny
47 = ulx userdenyid
48 = ulx voteecho
49 = xgui_gmsettings
50 = xgui_managebans
51 = xgui_managegroups
52 = xgui_svsettings
inherit_from = admin
james' group of himself:
allow:
inherit_from = superadmin
user:
allow:
1 = ulx asay
2 = ulx help
3 = ulx motd
4 = ulx psay
5 = ulx thetime
6 = ulx usermanagementhelp
7 = ulx votemap
8 = ulx who


ULib.ucl.authed (#=4):
333433934:
group = user
allow:
deny:
guest = true
3812254862:
group = user
allow:
deny:
guest = true
3763503357:
group = user
allow:
deny:
guest = true
3252334574:
group = user
allow:
deny:
guest = true


Garrysmod default file (#=2):
superadmin:
admin:


Active legacy addons on this server:
TTT Scripts              by Jason2010, Ollie, Q4-Bi., version 1 (25/11/12)
Terror Town ulx commands by Bender180 and Skillz, version 1 (00/00/00)
ULX_GlobalBanModule      by Adobe Ninja & NigNog, version 0.6b (06/12/2012)
faith                    by q4, version nil (nil)
jihadbomb                by A Traitor amongst Terrorists, version nil (nil)
pointshopWorking         by nil, version nil (nil)
pointshopaddonmysql      by nil, version nil (nil)
trails                   by q4, version nil (nil)
ulib                     by Team Ulysses, version 2.5 (01/27/13)
ulx                      by Team Ulysses, version 3.5999 (01/27/13)

(I have no idea how to svn on hypanova if that could fix it  )

[Megiddo]

It's working for me. Can you give detailed steps on how you're banning exactly?

[Scratch]

Using the console, I demoted myself to moderator

I press NUM2 (bind) to open the ULX XGUI

Upon hitting the ban section in it's appropriate group, the error message shows up in the console, AND the XGUI becomes stuck on my display.

That's literally it

[JamminR]

We occasionally see ULX temp ban file (and it stores who/why reasons for perm bans too) corruption.
This may be due to it's size, or in someway, odd ascii in a name that got banned.
Mind attaching your server's gmod/data/ulx/bans.txt file?

[Scratch]

It was in the ulib folder, not the ulx folder

[MrPresident]

I only see one name that uses strange characters.

Make a backup of that bans.txt file and delete it. Restart your server and try to use ULX/XGUI as normal. See if this fixes your problem.

[Scratch]

I deleted bans.txt, only for it to appear again, something strange

[Scratch]

Okay, So I went back into permission management

Bans is red


Is this because it might be broken?
Or I limited bans from mods to 1~5000 minutes?

[Scratch]

Okay, so I found out how to fix it, I just revoked and re-allowed access to the command,

I guess the error was caused by the restriction of allowed ban time

[Megiddo]

I see the problem now, you had an invalid character '~' in the restrictions. I'm assuming you mean to use ':' instead. We should be erroring more gracefully though, so I've added it to our issues list.