Temp bans not working since updates

[Storm]

Hi I am having a problem in that, on multiple servers, I do a tempban and the player is kicked. Then he returns. I have checked the bans.txt to ensure the ban is properly recorded there and it is. It seems the server just isn't reading the bans.txt file. Is there anyway I can troubleshoot this problem to figure out why it is happening? I have svn for ULX/ULIB so I do have the latest copy. Thank you.

[Stickly Man!]

This could be caused by any sourcebans or external ban type system you have enabled on your server. I'll see if I can confirm if this occurs on a vanilla server with ULX, when I have a chance. (If anyone else would like to test this, I'd appreciate it! I hate being busy all of the time lol)

[Avoid]

Hello there,
I do indeed run sourcebans aswell but I tested it nevertheless with and without sourcebans being active, but it works perfectly fine.
The ban does get written to the bans file aswell as being listed in the banlist using listid.

Code: [Select]

--server--
ulx ban avoid 50
(Console) banned Avoid for 50 minute(s)
ServerLog: [ULX] (Console) banned Avoid for 50 minute(s)
listid
62 STEAM_0:1:19337211 : 50.000 min

--client--
Connecting to IP:27015...
You have been banned from this server.


[Storm]

I don't have Sourcebans or any other external banning system, just ULX/ULIB. Here is what I see when I tested this over and over when I ban from rcon"

This is the chat log:
[20:33:53] (Console) banned steamid STEAM_0:1:xxx01830(Joe)  for 5 minute(s) (TEST)
[20:33:54] Dropped "Joe" from server<STEAM_0:1:xxx01830
[20:34:17] Client "Joe" connected.

The console log never even shows any ban or even that the player left the server'

And here is bans.txt:
"STEAM_0:1:xxx01830(Joe) "   
{
   "reason"   "TEST"
   "admin"   "(Console)"
   "unban"   1405991653
   "time"   1405991053
   "name"   "Joe"
}

So it does get recorded there but banned player can rejoin immediately.

This happens when the player is banned for any amount of time.

When a ban is done from the console and the player is not on the server, the same thing happens: the console log doesn't show the ban at all, the bans.txt file does show the ban. The player can get right back in.

EDIT: I tested this on 10 different servers running 5 different Gmod gamemodes and the player got right back in after being banned on all.  As an additional test, I did the console bans from 1) HLSW and then 2) the control  panel of my gameserver rcon and it was the same on both. Again, I have svn for ULX/ULIB.

I am banning from the console using ulx banid STEAM:0:1:XXX01830 10 "TEST" and it kicks the player but he returns.

[Stickly Man!]

Yup, I can confirm this is a bug, and it only applies when using "ulx banid". Will have it fixed momentarily!

[Stickly Man!]

Whoops. That one was my bad. The steamID var in the ulx banid function got modified before sending it to the ulx.logfancyadmin, so my previous fix that moved the ban function UNDER the log function caused the steamID to be incorrect. But it's all good now!

[Storm]

Yes this fixed it thanks! But I have done a lot of bans that haven't worked over the past days and the correct files are sitting in my bans.txt. Do I need to reenter them or will your fix now keep the banned players out since those bans are correct?

[Stickly Man!]

You'll probably need to go through your banned_users.cfg and bans.txt file manually and fix the ones that were broken.

In banned_users.cfg, remove the "STEAM_ID_PENDING" line, if it exists.
Then, in the bans.txt file, just find any SteamIDs that look like:  "STEAM_0:1:123456 (Player Name)" and shorten it down to be the SteamID only, then double check that the SteamID is in the banned_users.cfg as well.
Save both files, then immediately restart your server so the changes don't get overwritten (or move the files off your your server, edit them, then transfer them back on.)

[Storm]

Thanks! Just a question, when I ban from the console I now get this message:

ServerLog: [ULX] (Console) banned steamid nil for 10080 minute(s)

instead of:

[17:05:54] (Console) banned steamid STEAM_0:1:4xxx02 for 10080 minute(s)

Is there any way to put the steamid back in the ban message so we can keep track of who we banned? The same thing happens for temp bans.

[Stickly Man!]

Hmm, I seem to be having trouble replicating that. Here's what I see in my console:

Code: [Select]

ulx banid STEAM_0:1:2xxxxx9
(Console) banned steamid STEAM_0:1:2xxxxx9([ULX]Stickly Man!)  permanently
ServerLog: [ULX] (Console) banned steamid STEAM_0:1:2xxxxx9([ULX]Stickly Man!) permanently
Dropped [ULX]Stickly Man! from server (Kicked by Console (Banned permanently: ))
You absolutely sure all of your files got up-to-date?

[Storm]

When the player is on the server and you banid, the "nil" doesn't occur. Can you please retest a banid when the player isn't on the server? That's when it happens.

[Stickly Man!]

Ah yes, I had triggered it once, but I forgot how. Will have a fix soon: https://github.com/Nayruden/Ulysses/issues/326

[Stickly Man!]

Fixed! Minor oversight on my part. X| Thanks for the heads up!

[Storm]

Thanks so much! It works fine now.