Author Topic: URGENT: Submit bug reports NOW! (Read 8356 times)

Megiddo · « **on:** September 19, 2007, 05:21:19 PM »

We have now implemented every feature planned for ULX 3.20/ULib 2.10. This means we're now going to sit on our hands for the next 24 (or so) hours to see if any bugs surface. Please tell us IMMEDIATELY if there are any bugs or errors!

If there aren't any bugs that can't be easily fixed, we'll go ahead with a release of 3.20 tomorrow, September 20th.

Thanks for your support!

-Team Ulysses

Chironex · « **Reply #1 on:** September 19, 2007, 09:17:10 PM »

Will do, but there isn't much players on our server these days

Also, can you give a GMT time, since i'm french and it's now 06:30, morning, 20 september

Edit: sorry i've read 3:20 instead of 3.20 lol (tired)

Chironex · « **Reply #2 on:** September 19, 2007, 10:51:04 PM »

OK well i have tested all clients commands on me and a player, no bugs has been found
Unbanning an user from the bans menu work fine
Changing maps is ok

Haven't tested much others things, but this seems ok for a release.

In 2 words, awesome work

But i have some suggestions about menus, should i suggest them now ?

Megiddo · « **Reply #3 on:** September 19, 2007, 11:16:32 PM »

Yes go ahead. Please test the new user administration commands and the temp ban stay alive over server crash capabilities.

Chironex · « **Reply #4 on:** September 20, 2007, 01:32:42 AM »

Well i have tested banning myself for 5 min. 2 min after the ban i stopped and restarted the server, i was still banned for 3 min. So it seem ok but maybe a shutdown/restart doesn't do the same effect as a real crash.

But it seems that the ban menu have a bug:

Before banning myself, the ban list contained all the bans that are in banned_users.cfg. When i was unbanned, i rejoined and checked the list: there was only me in the ban list this time.

I'm maybe wrong, but i think this list contain only the users banned from ulx commands (but before banning someone from ulx commands, the list contain the content of banned_users.cfg).

EDIT: It seems that the list show all bans again. Weird.

Also, about this ban list, you should add a button "Clear unbanned users" or something. Because even me being unbanned, there was a button at the right side to unban me. Or maybe add an option in the config file "auto_clear_unbanned_users" or whatever.

What you mean user administration commands ?

These ?

Code: [Select]

Category: User Management
	o addgroup <group> [<inherit>] - Create a new group with optional inheritance.
	o adduser <user> <group> [<immunity>] - Use with no args for more help.
	o groupallow <group> <acess> [<revoke>] - Allow group access to string access. If optional revoke is true, then revoke access 
	o groupdeny <group> <acess> [<remove>] - Deny a group access to string access. If remove is true then remove access from the d
	o userallow <user> <command> - Specifically allows the user access to command. (IE: "ulx slap")
	o userdeny <user> <command> - Specifically denies the user access to command.

Actually i can't test, as no one is in the server

About menus suggestions:

- Well i had already suggested that, i don''t know if you remember: in the Client menu, i would like to have only options that the player isn't..sorry i don't know how to explain clearly..For example if i'm muted, only create a button Unmute but no button Mute as i'm already muted

and same for all others toggleable buttons

- In the map menu, it seems that you do lines of 5, then go to next line, etc, but they are sorted in rows, hmm..I think it will be better to make rows of 16 maps, also because maybe it depend of the user's screen resolution (i run on windowed 1024*768) , there is a big unused space, and also, enlarge buttons a bit but that's not really needed

:

So maybe make the window size depending of the maps count
Only suggestions

PS: I've just looked my console, there is some usermessages warnings:

Code: [Select]

[UCL] Access set.
Hey 'kyzer' - You're in the 'superadmin' group on this server.
This server is running Ghost Script v1.8!
Welcome to \\SILENTS// PHX | Wire | LS! We're playing gm_construct.
This server is running ULib version 2.10.
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ULX version 3.20 loaded.

Code: [Select]

[UCL] Access set.
Hey 'kyzer' - You're in the 'superadmin' group on this server.
This server is running Ghost Script v1.8!
Welcome to \\SILENTS// PHX | Wire | LS! We're playing gm_flatgrass.
This server is running ULib version 2.10.
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ReadUsermessageString: String Not Pooled!
ULX version 3.20 loaded.
You're playing on \\SILENTS// PHX | Wire | LS, enjoy your stay!

PPS: Here is my groups.txt frshly created in the data folder:

Code: [Select]

"superadmin"	
{
	"deny"	
	{
	}
	"allow"	
	{
		"ulx hiddenecho"
		"ulx rcon"
		"ulx luarun"
		"ulx cexec"
		"ulx ent"
		"ulx adduser"
		"ulx userallow"
		"ulx userdeny"
		"ulx addgroup"
		"ulx groupallow"
		"ulx groupdeny"
		"overcomeimmunity"
	}
	"inherit_from"	
	{
		"admin"
	}
}
"admin"	
{
	"deny"	
	{
	}
	"allow"	
	{
		"ulib_passtime"
		"ulib_passtimeout"
		"ulx spawnecho"
		"ulx tsay"
		"ulx csay"
		"ulx gimp"
		"ulx mute"
		"ulx ungimp"
		"ulx unmute"
		"ulx gag"
		"ulx ungag"
		"ulx chattime"
		"ulx welcomemessage"
		"ulx slap"
		"ulx whip"
		"ulx slay"
		"ulx sslay"
		"ulx ignite"
		"ulx playsound"
		"ulx freeze"
		"ulx unfreeze"
		"ulx god"
		"ulx ungod"
		"ulx noclip"
		"ulx hp"
		"ulx cloak"
		"ulx uncloak"
		"ulx blind"
		"ulx unblind"
		"ulx jail"
		"ulx unjail"
		"ulx ghost"
		"ulx unghost"
		"ulx ragdoll"
		"ulx unragdoll"
		"ulx maul"
		"ulx adminmenu"
		"ulx clientmenu"
		"ulx mapsmenu"
		"ulx showmotd"
		"ulx banmenu"
		"ulx exec"
		"ulx rslotsmode"
		"ulx rslots"
		"ulx rslotsvisible"
		"ulx reservedslots"
		"ulx bring"
		"ulx goto"
		"ulx send"
		"ulx teleport"
		"ulx tooldeny"
		"ulx toolallow"
		"ulx tooldenyuser"
		"ulx toolallowuser"
		"ulx tooldenyoverride"
		"ulx map"
		"ulx kick"
		"ulx ban"
		"ulx banid"
		"ulx unban"
		"ulx spectate"
		"ulx mingekick"
		"ulx physgunplayer"
		"ulx vote"
		"ulx votemap2"
		"ulx votekick"
		"ulx voteban"
		"ulx veto"
	}
	"inherit_from"	
	{
		"operator"
	}
}
"user"	
{
	"deny"	
	{
	}
	"allow"	
	{
		"ulx"
		"ulx help"
		"ulx psay"
		"ulx asay"
		"ulx thetime"
		"ulx menu"
		"ulx_valueupdate"
		"ulx_cvar"
		"ulx_getgamemodes"
		"ulx motd"
		"ulx_getbans"
		"ulx who"
		"ulx votemap"
	}
	"inherit_from"	
	{
	}
}
"respected"	
{
}
"operator"	
{
	"deny"	
	{
	}
	"allow"	
	{
		"ulx seeasay"
	}
	"inherit_from"	
	{
	}
}
"none"	
{
	"deny"	
	{
	}
	"allow"	
	{
		"ulx logecho"
		"ulx logfile"
		"ulx logevents"
		"ulx logchat"
		"ulx logspawns"
		"ulx logspawnsecho"
		"ulx logdir"
		"ulx addgimpsay"
		"ulx addadvert"
		"ulx addcsayadvert"
		"ulx addforceddownload"
		"ulx debuginfo"
		"ulx voteecho"
		"ulx votemap2successratio"
		"ulx votemap2minvotes"
		"ulx votekicksuccessratio"
		"ulx votekickminvotes"
		"ulx votebansuccessratio"
		"ulx votebanminvotes"
		"ulx votemapenabled"
		"ulx votemapmintime"
		"ulx votemapwaittime"
		"ulx votemapsuccessratio"
		"ulx votemapminvotes"
		"ulx votemapvetotime"
		"ulx votemapmapmode"
		"ulx votemapaddmap"
	}
	"inherit_from"	
	{
	}
}

It seem that i can't execute any of the commands of the "none" group. And i'm superadmin. Bug ?

Another small bug and the last one for this post: The log line "Server is shutting down/changing levels." is only logged when changing level, not when server is shutting down.

JamminR · « **Reply #5 on:** September 20, 2007, 04:19:40 AM »

Megiddo, I too have seen the userstring not pooled several times on our dev server.

Neico · « **Reply #6 on:** September 20, 2007, 10:55:48 AM »

there still some things in the bugtracker do do for me i want the access menu with the release maybe finishing that before the next release

(with the group commands it should now not be that hard to make the menu

)

(and maybe my skin for ulx all i need for the rounded version is a bit code that makes the rounded lines at the corners :S (megiddo you wanted to make me that bit of code

))

Megiddo · « **Reply #7 on:** September 20, 2007, 12:56:43 PM »

Quote from: Kyzer on September 20, 2007, 01:32:42 AM

Well i have tested banning myself for 5 min. 2 min after the ban i stopped and restarted the server, i was still banned for 3 min. So it seem ok but maybe a shutdown/restart doesn't do the same effect as a real crash.

It would have the same effect, so thanks!

Quote from: Kyzer on September 20, 2007, 01:32:42 AM

But it seems that the ban menu have a bug:

Before banning myself, the ban list contained all the bans that are in banned_users.cfg. When i was unbanned, i rejoined and checked the list: there was only me in the ban list this time.

I'm maybe wrong, but i think this list contain only the users banned from ulx commands (but before banning someone from ulx commands, the list contain the content of banned_users.cfg).

EDIT: It seems that the list show all bans again. Weird.

Also, about this ban list, you should add a button "Clear unbanned users" or something. Because even me being unbanned, there was a button at the right side to unban me. Or maybe add an option in the config file "auto_clear_unbanned_users" or whatever.

Hmm, just experienced this myself. Not sure why the list is clearing, but I changed it on SVN so it refreshes the ban list every time the menu is opened.

Quote from: Kyzer on September 20, 2007, 01:32:42 AM

What you mean user administration commands ?

These ?
Code: [Select]
Category: User Management o addgroup <group> [<inherit>] - Create a new group with optional inheritance. o adduser <user> <group> [<immunity>] - Use with no args for more help. o groupallow <group> <acess> [<revoke>] - Allow group access to string access. If optional revoke is true, then revoke access o groupdeny <group> <acess> [<remove>] - Deny a group access to string access. If remove is true then remove access from the d o userallow <user> <command> - Specifically allows the user access to command. (IE: "ulx slap") o userdeny <user> <command> - Specifically denies the user access to command.
Actually i can't test, as no one is in the server

Yes those.

Quote from: Kyzer on September 20, 2007, 01:32:42 AM

About menus suggestions:

- Well i had already suggested that, i don''t know if you remember: in the Client menu, i would like to have only options that the player isn't..sorry i don't know how to explain clearly..For example if i'm muted, only create a button Unmute but no button Mute as i'm already muted and same for all others toggleable buttons

- In the map menu, it seems that you do lines of 5, then go to next line, etc, but they are sorted in rows, hmm..I think it will be better to make rows of 16 maps, also because maybe it depend of the user's screen resolution (i run on windowed 1024*768) , there is a big unused space, and also, enlarge buttons a bit but that's not really needed :

So maybe make the window size depending of the maps count
Only suggestions

Too much work for too little gain in both cases.

I made the main menu dynamically sized but it was a pain in the but and it's really hard to read the code. I prefer having all the menus 640x480 no matter what too, nice to have standards.

They're good ideas though, and thanks for the suggestions.

Quote from: Kyzer on September 20, 2007, 01:32:42 AM

PS: I've just looked my console, there is some usermessages warnings:
Code: [Select]
[UCL] Access set. Hey 'kyzer' - You're in the 'superadmin' group on this server. This server is running Ghost Script v1.8! Welcome to \\SILENTS// PHX | Wire | LS! We're playing gm_construct. This server is running ULib version 2.10. ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ULX version 3.20 loaded.
Code: [Select]
[UCL] Access set. Hey 'kyzer' - You're in the 'superadmin' group on this server. This server is running Ghost Script v1.8! Welcome to \\SILENTS// PHX | Wire | LS! We're playing gm_flatgrass. This server is running ULib version 2.10. ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ReadUsermessageString: String Not Pooled! ULX version 3.20 loaded. You're playing on \\SILENTS// PHX | Wire | LS, enjoy your stay!

PPS: Here is my groups.txt frshly created in the data folder:
Code: [Select]
"superadmin" { "deny" { } "allow" { "ulx hiddenecho" "ulx rcon" "ulx luarun" "ulx cexec" "ulx ent" "ulx adduser" "ulx userallow" "ulx userdeny" "ulx addgroup" "ulx groupallow" "ulx groupdeny" "overcomeimmunity" } "inherit_from" { "admin" } } "admin" { "deny" { } "allow" { "ulib_passtime" "ulib_passtimeout" "ulx spawnecho" "ulx tsay" "ulx csay" "ulx gimp" "ulx mute" "ulx ungimp" "ulx unmute" "ulx gag" "ulx ungag" "ulx chattime" "ulx welcomemessage" "ulx slap" "ulx whip" "ulx slay" "ulx sslay" "ulx ignite" "ulx playsound" "ulx freeze" "ulx unfreeze" "ulx god" "ulx ungod" "ulx noclip" "ulx hp" "ulx cloak" "ulx uncloak" "ulx blind" "ulx unblind" "ulx jail" "ulx unjail" "ulx ghost" "ulx unghost" "ulx ragdoll" "ulx unragdoll" "ulx maul" "ulx adminmenu" "ulx clientmenu" "ulx mapsmenu" "ulx showmotd" "ulx banmenu" "ulx exec" "ulx rslotsmode" "ulx rslots" "ulx rslotsvisible" "ulx reservedslots" "ulx bring" "ulx goto" "ulx send" "ulx teleport" "ulx tooldeny" "ulx toolallow" "ulx tooldenyuser" "ulx toolallowuser" "ulx tooldenyoverride" "ulx map" "ulx kick" "ulx ban" "ulx banid" "ulx unban" "ulx spectate" "ulx mingekick" "ulx physgunplayer" "ulx vote" "ulx votemap2" "ulx votekick" "ulx voteban" "ulx veto" } "inherit_from" { "operator" } } "user" { "deny" { } "allow" { "ulx" "ulx help" "ulx psay" "ulx asay" "ulx thetime" "ulx menu" "ulx_valueupdate" "ulx_cvar" "ulx_getgamemodes" "ulx motd" "ulx_getbans" "ulx who" "ulx votemap" } "inherit_from" { } } "respected" { } "operator" { "deny" { } "allow" { "ulx seeasay" } "inherit_from" { } } "none" { "deny" { } "allow" { "ulx logecho" "ulx logfile" "ulx logevents" "ulx logchat" "ulx logspawns" "ulx logspawnsecho" "ulx logdir" "ulx addgimpsay" "ulx addadvert" "ulx addcsayadvert" "ulx addforceddownload" "ulx debuginfo" "ulx voteecho" "ulx votemap2successratio" "ulx votemap2minvotes" "ulx votekicksuccessratio" "ulx votekickminvotes" "ulx votebansuccessratio" "ulx votebanminvotes" "ulx votemapenabled" "ulx votemapmintime" "ulx votemapwaittime" "ulx votemapsuccessratio" "ulx votemapminvotes" "ulx votemapvetotime" "ulx votemapmapmode" "ulx votemapaddmap" } "inherit_from" { } }

This seems to be a GMod bug, it only happens occasionally and is fixed by rejoining.

Quote from: Kyzer on September 20, 2007, 01:32:42 AM

It seem that i can't execute any of the commands of the "none" group. And i'm superadmin. Bug ?

Another small bug and the last one for this post: The log line "Server is shutting down/changing levels." is only logged when changing level, not when server is shutting down.

The group "none" means that no one can execute it. A bit of a misnomer having "none" and "allow", I know... but that's how things worked out.

Didn't know about the log issue. I'll be checking that out.

As far as time we're releasing, it'll be whenever we feel like everyone is happy about being able to test everything sufficiently. So let us know if you find more bugs! We'll release in about 6-7 hours if we don't hear back on any issues.

Megiddo · « **Reply #8 on:** September 20, 2007, 01:39:37 PM »

Okay, just spent quite a while testing with Neico, and the new user management commands aren't quite up to the speed I thought they were. No offense to you spbogie, guess we just had a miscommunication.

Anyways, the release will be put off until at least tomorrow, and here's the list of things we'll be fixing/implementing in the mean time:

~~ulx group* not logging actions~~
~~get ulx group* to update autocomplete after use~~
~~Only show commands you have access to on clientmenu~~
revoke option on ulx user*, like ulx group*
~~ulx removeuser, removegroup~~
~~add safety protecting superadmin on ulx group* and ulx removegroup~~
~~check into why bansmenu is blank every other load~~

Keep testing and let us know if there's anything else we should fix!

Golden-Death · « **Reply #9 on:** September 20, 2007, 03:25:08 PM »

Quote from: Megiddo on September 20, 2007, 01:39:37 PM

Okay, just spent quite a while testing with Neico, and the new user management commands aren't quite up to the speed I thought they were. No offense to you spbogie, guess we just had a miscommunication.

Anyways, the release will be put off until at least tomorrow, and here's the list of things we'll be fixing/implementing in the mean time:
Code: [Select]
Golden-Death demands immediate haltage of the release.
Keep testing and let us know if there's anything else we should fix!

Kk?

Chironex · « **Reply #10 on:** September 20, 2007, 03:39:45 PM »

In the Admin menu, there is 4 buttons:

Allow NPCs, etc.

Well, if i click any of them, the text disappear, like:

Code: [Select]

before:

[ Allow NPCS ]

after:

[            ]

Same for each buttons. Hmm i have no idea, yesterday it worked fine

(if i remember)

PS: Reloaded the map, now appear fine, weird

Chironex · « **Reply #11 on:** September 20, 2007, 04:33:02 PM »

Small bug in the "ulx help", long lines are cut, example

Code: [Select]

	o groupallow <group> <acess> [<revoke>] - Allow group access to string access. If optional revoke is true, then revoke access 
	o groupdeny <group> <acess> [<remove>] - Deny a group access to string access. If remove is true then remove access from the d

Chironex · « **Reply #12 on:** September 20, 2007, 07:56:32 PM »

Sorry i start new posts so you see them

I think CSayAdvert is bugged, this:

Code: [Select]

ulx addCsayAdvert "A" 255 0 0 10 5
ulx addCsayAdvert "B" 255 0 0 10 5
ulx addCsayAdvert "C" 255 0 0 10 5
ulx addCsayAdvert "D" 255 0 0 10 5
ulx addCsayAdvert "E" 255 0 0 10 5

will always display C on the screen.

Also looking the console, it prints all adverts so i think it display them all -quickly- as well but we see only the last.

Code: [Select]

B
E
D
A
C

Note: this is an old bug but should be fixed

Megiddo · « **Reply #13 on:** September 20, 2007, 08:24:57 PM »

That's because they're all showing at once Kyzer. If you want them to show in sequence, put them in a group.

Chironex · « **Reply #14 on:** September 20, 2007, 08:38:03 PM »

Hmm, ok sorry :p

But then, when you say

Code: [Select]

// If you specify a group, adverts in that group will run sequentially instead of simultaneously, what's the point of having NO groups?

Hmm well, i've tried with a group,

Code: [Select]

ulx addCsayAdvert "A" 255 0 0 10 5 a
ulx addCsayAdvert "B" 255 0 0 10 5 a
ulx addCsayAdvert "C" 255 0 0 10 5 a
ulx addCsayAdvert "D" 255 0 0 10 5 a
ulx addCsayAdvert "E" 255 0 0 10 5 a

but...

Code: [Select]

A
Warning: Unhandled usermessage 'ULibLuaFn'
B
Warning: Unhandled usermessage 'ULibLuaFn'
C
Warning: Unhandled usermessage 'ULibLuaFn'
D
Warning: Unhandled usermessage 'ULibLuaFn'
E
Warning: Unhandled usermessage 'ULibLuaFn'

and it doesn't show any ads, the whole ulx crash (nothing works)

Well i rebooted the server and now it seem ok - weird again and sorry for posting false bugs

Ulysses

Author Topic: URGENT: Submit bug reports NOW! (Read 8356 times)

Megiddo

URGENT: Submit bug reports NOW!

Chironex

Re: URGENT: Submit bug reports NOW!

Chironex

Re: URGENT: Submit bug reports NOW!

Megiddo

Re: URGENT: Submit bug reports NOW!

Chironex

Re: URGENT: Submit bug reports NOW!

JamminR

Re: URGENT: Submit bug reports NOW!

Neico

Re: URGENT: Submit bug reports NOW!

Megiddo

Re: URGENT: Submit bug reports NOW!

Megiddo

Re: URGENT: Submit bug reports NOW!

Golden-Death

Re: URGENT: Submit bug reports NOW!

Chironex

Re: URGENT: Submit bug reports NOW!

Chironex

Re: URGENT: Submit bug reports NOW!

Chironex

Re: URGENT: Submit bug reports NOW!

Megiddo

Re: URGENT: Submit bug reports NOW!

Chironex

Re: URGENT: Submit bug reports NOW!