New GMOD Update; Ban Format Broken?

[Hollistupid]

While using ULX ban- didn't happen before the update now this happens

[Storm]

Yes i got the same thing.

[Stickly Man!]

Wait- what's the issue here? What command did you enter that gave this result?

[Storm]

If you go on the ulx menu, to utility and ban a player on the server for any amount of time, the echo that shows on the server and in the logs is that (console) was banned, rather than using the player's name. Also, oddly, 2 banned players have returned immediately but I need to investigate this more before posting it as a problem.

Here is an example of what happens with a ban from the ulx menu:
[17:06:07] Adminxyz  banned (Console) permanently (troll)

The player had a name, not console.

[Yoz]

I am having this as well, only started happening after the GMOD update today.

[Zombine]

I can also confirm this is happening. Banning a player replaces the banned player portion of the ban echo with (Console)
"You banned (Console) permanently."

[Decicus]

Would this be related to it?

Player:Kick and Player:Ban kick/ban reasons are now optional and may contain newlines

http://www.garrysmod.com/2014/07/08/14-07-08/

[Stickly Man!]

On it.
https://github.com/Nayruden/Ulysses/issues/310

I'll hopefully get a chance to investigate later tonight.

[Neku]

On it.
https://github.com/Nayruden/Ulysses/issues/310

I'll hopefully get a chance to investigate later tonight.

What do you think could be causing this?
I want to take a look at it myself, in case you don't have time.

http://i.imgur.com/LZvbFOe.jpg

[Stickly Man!]

Go ahead and look! I wanted to get to this issue tonight, but it looks like a lot more users are having issues with users being randomly removed from groups, so I'm investigating that one at the moment

[Stickly Man!]

I had a second to look at it and it was pretty simple, and should now be fixed! Please update and test for me.

The ULX ban code first banned the player (and kicked them), then called the code to log and display the action. The fancyLog code had a bit of code to loop through the available players to eventually get the name of and display the user that was the targeted player, but by the time it ran, the user had already been kicked, thus it defaulted to say "(Console)". I changed it to log the action before performing the ban, which is not recommended, but.. it works now

[Hollistupid]

Works man, thanks

[Storm]

Makes sense because before the update, in the logs, the ban for the player showed first, then the disconnect message. I noticed after the update, it was reversed. When will this be rolled out to update in svn?

[Stickly Man!]

Our SVN links pull directly from our git repository (Thanks to GitHub!), so an SVN update should grab all of our recent changes.

[Avoid]

Well, thanks for the quick update, was kind of confused once a moderator banned the console! :')
But I must say I am really suprised the update didn't break anything major!